-
Notifications
You must be signed in to change notification settings - Fork 901
[UEPR-401] Display a label beside the username #9913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UEPR-401] Display a label beside the username #9913
Conversation
|
i'm calmer now, so could an ST member explain how this is not rejected per 8.2 of TOLORS?
|
|
how is adding paywalls lightweight? |
|
the scratch team has historically rejected this for a reason, albeit a good one. a feature like this is an easy route to bragging and bullying, which i'm sure nobody here wants. i personally believe the scratch membership is a good thing, but we should do our best to construct it in a way that keeps bragging and bullying to a minimum. i personally don't think this is a step in that direction. |
|
Hi folks! Thank you very much for sharing your thoughts and feelings. I appreciate that you care a lot about Scratch and its future. Please see this issue for a message about membership features like this. |
| MEMBER: 1 | ||
| }; | ||
|
|
||
| // Expand with other labels if we starting supporting multiple types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
|
||
| CuratorInviteMessage.propTypes = { | ||
| actorUsername: PropTypes.string.isRequired, | ||
| actorLabel: PropTypes.oneOf(Object.values(MembershipLabel.LABEL_TYPE)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for being specific with the prop type!
…tion/scratch-www into UEPR-401-display-label-beside-username
2d2bb3f
into
scratchfoundation:release/membership-program
Resolves:
UEPR-401
Changes:
Reason for changes:
This PR is part of an ongoing effort to introduce a couple of optional, lightweight incentives for Scratch supporters.